Skip to content

Commit da9720c

Browse files
gmarsayGuillaume Marsayjustinkambic
authored
[Heartbeat] Change size of data on ICMP packet (#29948)
* [Heartbeat] Change size of data on ICMP packet * Add CHANGELOG entry. Co-authored-by: Guillaume Marsay <guillaume.marsay@mediactivegroup.com> Co-authored-by: Justin Kambic <jk@elastic.co>
1 parent b462430 commit da9720c

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

CHANGELOG.next.asciidoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
5252
- Fix broken macOS ICMP python e2e test. {pull}29900[29900]
5353
- Only add monitor.status to browser events when summary. {pull}29460[29460]
5454
- Also add summary to journeys for which the synthetics runner crashes. {pull}29606[29606]
55+
- Update size of ICMP packets to adhere to standard min size. {pull}29948[29948]
5556

5657
*Metricbeat*
5758

heartbeat/monitors/active/icmp/stdloop.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ func (l *stdICMPLoop) sendEchoRequest(addr *net.IPAddr) (*requestContext, error)
346346
l.requests[id] = ctx
347347
l.mutex.Unlock()
348348

349-
payloadBuf := make([]byte, 0, 8)
349+
payloadBuf := make([]byte, 48, 48)
350350
payload := bytes.NewBuffer(payloadBuf)
351351
ts := time.Now()
352352
binary.Write(payload, binary.BigEndian, ts.UnixNano())

0 commit comments

Comments
 (0)