Skip to content

Commit bec7603

Browse files
authored
elasticsearch: set _type=doc (#3757)
The `_type` field is deprecated per elastic/elasticsearch#15613
1 parent 641323a commit bec7603

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

CHANGELOG.asciidoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ https://github.com/elastic/beats/compare/v5.1.1...master[Check the HEAD diff]
1717
- Change beat generator. Use `$GOPATH/src/github.com/elastic/beats/script/generate.py` to generate a beat. {pull}3452[3452]
1818
- Configuration files must be owned by the user running the beat or by root, and
1919
they must not be writable by others. {pull}3544[3544] {pull}3689[3689]
20+
- Usage of field `_type` is now ignored and hardcoded to `doc`. {pull}3757[3757]
2021

2122
*Filebeat*
2223
- Always use absolute path for event and registry. This can lead to issues when relative paths were used before. {pull}3328[3328]

libbeat/outputs/elasticsearch/client.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,10 @@ var (
9696
errExcpectedObjectEnd = errors.New("expected end of object")
9797
)
9898

99+
const (
100+
eventType = "doc"
101+
)
102+
99103
// NewClient instantiates a new client.
100104
func NewClient(
101105
s ClientSettings,
@@ -328,7 +332,7 @@ func createEventBulkMeta(
328332
return bulkMeta{
329333
Index: bulkMetaIndex{
330334
Index: getIndex(event, index),
331-
DocType: event["type"].(string),
335+
DocType: eventType,
332336
},
333337
}
334338
}
@@ -346,7 +350,7 @@ func createEventBulkMeta(
346350
Index: bulkMetaIndex{
347351
Index: getIndex(event, index),
348352
Pipeline: pipeline,
349-
DocType: event["type"].(string),
353+
DocType: eventType,
350354
},
351355
}
352356
}
@@ -548,7 +552,6 @@ func (client *Client) PublishEvent(data outputs.Data) error {
548552

549553
event := data.Event
550554
index := getIndex(event, client.index)
551-
typ := event["type"].(string)
552555

553556
debugf("Publish event: %s", event)
554557

@@ -562,9 +565,9 @@ func (client *Client) PublishEvent(data outputs.Data) error {
562565

563566
var status int
564567
if pipeline == "" {
565-
status, _, err = client.Index(index, typ, "", client.params, event)
568+
status, _, err = client.Index(index, eventType, "", client.params, event)
566569
} else {
567-
status, _, err = client.Ingest(index, typ, pipeline, "", client.params, event)
570+
status, _, err = client.Ingest(index, eventType, pipeline, "", client.params, event)
568571
}
569572

570573
// check indexing error

0 commit comments

Comments
 (0)