Skip to content

[7.17] update ironbank image product name (backport #8959)#8962

Merged
axw merged 1 commit into7.17from
mergify/bp/7.17/pr-8959
Aug 25, 2022
Merged

[7.17] update ironbank image product name (backport #8959)#8962
axw merged 1 commit into7.17from
mergify/bp/7.17/pr-8959

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Aug 25, 2022

This is an automatic backport of pull request #8959 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@jmlrt @axw @mergify
update ironbank image product name (#8959)
a521423 
This is required to automate the creation of the ironbank merge requests as the ubireleaser is using this field to compute the apm-server artifact url. For example it is now trying to retrieve https://artifacts.elastic.co/downloads/beats/apm-server-8.4.0-linux-x86_64.tar.gz instead of https://artifacts.elastic.co/downloads/apm-server/apm-server-8.4.0-linux-x86_64.tar.gz

Co-authored-by: Andrew Wilkins <axw@elastic.co>
(cherry picked from commit e751054)
@mergify mergify bot assigned jmlrt Aug 25, 2022
@ghost
Copy link
Copy Markdown

ghost commented Aug 25, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-25T01:28:08.355+0000

  • Duration: 45 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 4526
Skipped 17
Total 4543

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ghost
Copy link
Copy Markdown

ghost commented Aug 25, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 97.917% (47/48) 👍
Files 91.705% (199/217) 👍
Classes 92.662% (442/477) 👍
Methods 89.101% (1120/1257) 👍
Lines 76.78% (13620/17739) 👎 -0.017
Conditionals 100.0% (0/0) 💚

@ghost
Copy link
Copy Markdown

ghost commented Aug 25, 2022

📚 Go benchmark report

Diff with the 7.17 branch

name                                                                                                                                             old time/op    new time/op    delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/utility goos:linux goarch:amd64
ExtractIP/extractIP_remote:_10.11.12.13:8080,_Forwarded:_nil,_X-Real-IP:_54.55.101.102,_X-Forwarded-For:_54.56.103.104-12                           121ns ± 3%     125ns ± 3%   +3.14%  (p=0.040 n=5+5)
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
AggregateTransaction-12                                                                                                                            69.0ns ± 0%    68.7ns ± 0%   -0.44%  (p=0.024 n=5+5)
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
TraceGroups-12                                                                                                                                      153ns ±21%     123ns ± 6%  -19.99%  (p=0.032 n=5+5)
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
WriteTransaction/json_codec-12                                                                                                                     3.53µs ± 1%    3.65µs ± 2%   +3.20%  (p=0.008 n=5+5)
ReadEvents/nop_codec/1_events-12                                                                                                                   3.44µs ±64%    1.74µs ± 3%  -49.37%  (p=0.016 n=5+4)

name                                                                                                                                             old alloc/op   new alloc/op   delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
BackendProcessor/transactions.ndjson-12                                                                                                            48.3kB ± 1%    49.2kB ± 2%   +1.83%  (p=0.008 n=5+5)
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/utility goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/json_codec/1000_events-12                                                                                                               2.90MB ± 0%    2.92MB ± 1%   +0.79%  (p=0.032 n=4+5)
ReadEvents/nop_codec/10_events-12                                                                                                                  23.2kB ± 0%    23.2kB ± 0%   +0.09%  (p=0.048 n=5+5)

name                                                                                                                                             old allocs/op  new allocs/op  delta
pkg:github.com/elastic/apm-server/agentcfg goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/model/modelindexer goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/publish goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/utility goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling goos:linux goarch:amd64
pkg:github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage goos:linux goarch:amd64
ReadEvents/json_codec/1000_events-12                                                                                                                13.9k ± 0%     14.0k ± 0%   +0.30%  (p=0.032 n=4+5)

name                                                                                                                                             old speed      new speed      delta
pkg:github.com/elastic/apm-server/processor/stream goos:linux goarch:amd64

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

@axw axw merged commit 02f02a7 into 7.17 Aug 25, 2022
@axw axw deleted the mergify/bp/7.17/pr-8959 branch August 25, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jmlrt jmlrt jmlrt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmlrt jmlrt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmlrt @axw