apmbench: Support multiple apm servers in cloud#8119
Merged
marclop merged 2 commits intoelastic:mainfrom May 25, 2022
Merged
Conversation
Adds support for benchmarking multiple APM Servers running in ESS / ECE behind the cloud proxy. It uses the cloud proxy response headers and auto-discovers the number of APM Servers respond to the `/debug/vars` requests, and aggregates the final responses. Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
axw
reviewed
May 19, 2022
axw
approved these changes
May 25, 2022
lahsivjar
reviewed
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Adds support for benchmarking multiple APM Servers running in ESS / ECE
behind the cloud proxy. It uses the cloud proxy response headers and
auto-discovers the number of APM Servers respond to the
/debug/varsrequests, and aggregates the final responses.
Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Update package changelog.yml (only if changes toapmpackagehave been made)- [ ] Documentation has been updatedHow to test these changes
cd testing/benchmarkmake terraform.tfvarsterraform.tfvars:makemake run-benchmark BENCHMARK_AGENTS=1000 BENCHMARK_WARMUP=0 BENCHMARK_TIME=1mWarm up timeouts seem to be broken atm that's why they're set to 0.
Related issues
Closes #7841