benchmark: Add index-benchmark-results target#8011
Merged
marclop merged 2 commits intoelastic:mainfrom May 4, 2022
Merged
Conversation
Adds a new makefile target to the `testing/benchmark` workspace with a set of `GOBENCH_<FLAG>` variables that can be set to index the benchmark results to an Elasticsearch cluster that isn't the default (localhost). To re-use the existing makefile targets that set up the Go build env and command dependencies, a new `go.make` has been introduced which is now included by the main `Makefile` and `testing/benchmark/Makefile`. Signed-off-by: Marc Lopez Rubio <marc5.12@outlook.com>
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
axw
approved these changes
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Adds a new makefile target to the
testing/benchmarkworkspace with aset of
GOBENCH_<FLAG>variables that can be set to index the benchmarkresults to an Elasticsearch cluster that isn't the default (localhost).
To re-use the existing makefile targets that set up the Go build env and
command dependencies, a new
go.makehas been introduced which is nowincluded by the main
Makefileandtesting/benchmark/Makefile.Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Update package changelog.yml (only if changes toapmpackagehave been made)How to test these changes
docker-compose up -d && cd testing/benchmark && make. (Creates a new deployment in ESS).make run-benchmark BENCHMARK_TIME=30s BENCHMARK_COUNT=1make index-benchmark-results.gobench*)Related issues
Closes #7856