Skip to content

[7.x] Support for Node.js profiles (#4728)#4850

Merged
axw merged 1 commit intoelastic:7.xfrom
axw:backport/7.x/pr-4728
Feb 20, 2021
Merged

[7.x] Support for Node.js profiles (#4728)#4850
axw merged 1 commit intoelastic:7.xfrom
axw:backport/7.x/pr-4728

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented Feb 20, 2021

Backports the following commits to 7.x:

* Support for Node.js profiles

Implements support for Node.js profiles, by normalizing sample.count to samples.count and adding wall.microseconds as a supported value type.
# Conflicts:
#	changelogs/head.asciidoc
#	include/fields.go
@axw axw added the backport label Feb 20, 2021
@axw axw enabled auto-merge (squash) February 20, 2021 01:44
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #4850 (d972469) into 7.x (4175425) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              7.x    #4850      +/-   ##
==========================================
+ Coverage   76.72%   76.77%   +0.04%     
==========================================
  Files         166      166              
  Lines       10232    10237       +5     
==========================================
+ Hits         7851     7859       +8     
+ Misses       2381     2378       -3     
Impacted Files Coverage Δ
model/profile.go 100.00% <100.00%> (ø)
x-pack/apm-server/sampling/processor.go 78.63% <0.00%> (-0.91%) ⬇️
kibana/connecting_client.go 76.56% <0.00%> (+7.81%) ⬆️

@ghost
Copy link
Copy Markdown

ghost commented Feb 20, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4850 opened

  • Start Time: 2021-02-20T01:44:21.637+0000

  • Duration: 36 min 7 sec

  • Commit: d972469

Test stats 🧪

Test Results
Failed 0
Passed 4493
Skipped 126
Total 4619

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 3

Expand to view the steps failures

Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage
Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
Test Sync
  • Took 4 min 47 sec . View more details on here
  • Description: ./.ci/scripts/sync.sh

@axw axw merged commit daa0d5f into elastic:7.x Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants