Skip to content

[7.12] Use the apm-server version everywhere* (#4725)#4822

Merged
axw merged 1 commit intoelastic:7.12from
axw:backport/7.12/pr-4725
Feb 19, 2021
Merged

[7.12] Use the apm-server version everywhere* (#4725)#4822
axw merged 1 commit intoelastic:7.12from
axw:backport/7.12/pr-4725

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented Feb 19, 2021

Backports the following commits to 7.12:

* publish: parse version to set version_major

Instead of hardcoding the major version, parse the full version.

* beater: pass apm-server version into root handler

Rather than returning the libbeat version from the
root/healthcheck handler, inject the apm-server version
so it can be returned.

Also, in the integration tests use a hard-coded version
"1.2.3", so we don't have to change approval files each
time we bump the version. This should enable us to
automate the version bump.
# Conflicts:
#	beater/api/mux.go
#	beater/api/root/test_approved/integration/TestRootHandler_AuthorizationMiddleware/Authorized.approved.json
#	beater/test_approved_es_documents/TestPublishIntegrationErrors.approved.json
#	beater/test_approved_es_documents/TestPublishIntegrationEvents.approved.json
#	beater/test_approved_es_documents/TestPublishIntegrationMetricsets.approved.json
#	beater/test_approved_es_documents/TestPublishIntegrationMinimalEvents.approved.json
#	beater/test_approved_es_documents/TestPublishIntegrationProfileCPUProfile.approved.json
#	beater/test_approved_es_documents/TestPublishIntegrationProfileCPUProfileMetadata.approved.json
#	beater/test_approved_es_documents/TestPublishIntegrationProfileHeapProfile.approved.json
#	beater/test_approved_es_documents/TestPublishIntegrationSpans.approved.json
#	beater/test_approved_es_documents/TestPublishIntegrationTransactions.approved.json
#	publish/pub.go
@axw axw added the backport label Feb 19, 2021
@axw axw enabled auto-merge (squash) February 19, 2021 03:26
@ghost
Copy link
Copy Markdown

ghost commented Feb 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4822 opened

  • Start Time: 2021-02-19T03:27:12.082+0000

  • Duration: 37 min 36 sec

  • Commit: 16e72d7

Test stats 🧪

Test Results
Failed 0
Passed 4373
Skipped 126
Total 4499

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 3

Expand to view the steps failures

Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage
Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
Test Sync
  • Took 4 min 49 sec . View more details on here
  • Description: ./.ci/scripts/sync.sh

@axw axw merged commit 6574ba4 into elastic:7.12 Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant