Skip to content

[7.x] beater: run gmuxed gRPC server by default (#4618)#4784

Merged
axw merged 2 commits intoelastic:7.xfrom
axw:backport/7.x/pr-4618
Feb 18, 2021
Merged

[7.x] beater: run gmuxed gRPC server by default (#4618)#4784
axw merged 2 commits intoelastic:7.xfrom
axw:backport/7.x/pr-4618

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented Feb 18, 2021

Backports the following commits to 7.x:

* beater: run gmuxed gRPC server by default

Use gmux to run a gRPC server on the same port
as the Elastic APM HTTP server, and register the
Jaeger services by default.

When auth is enabled, it is necessary to configure
Jaeger to send an agent tag called "elastic-apm-auth".
This cannot be changed.

* systemtest/apmservertest: add TLS support

Self-signed certificate and key copied from
https://github.com/golang/go/blob/master/src/net/http/internal/testcert.go

* systemtest: add test for muxed Jaeger+TLS

* beater/jaeger: fix comment

* beater/jager: add deprecation notice

* Add changelog entry

* jaeger config will be removed in 8.0

* Add "Deprecated" changelog entry
# Conflicts:
#	NOTICE.txt
#	changelogs/head.asciidoc
@axw axw added the backport label Feb 18, 2021
@axw axw enabled auto-merge February 18, 2021 05:36
@ghost
Copy link
Copy Markdown

ghost commented Feb 18, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4784 updated

  • Start Time: 2021-02-18T05:45:59.203+0000

  • Duration: 54 min 51 sec

  • Commit: e06ebec

Test stats 🧪

Test Results
Failed 0
Passed 4373
Skipped 123
Total 4496

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 3

Expand to view the steps failures

Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage
Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
Test Sync
  • Took 3 min 12 sec . View more details on here
  • Description: ./.ci/scripts/sync.sh

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #4784 (e06ebec) into 7.x (3f5ab4e) will decrease coverage by 0.01%.
The diff coverage is 78.72%.

@@            Coverage Diff             @@
##              7.x    #4784      +/-   ##
==========================================
- Coverage   75.79%   75.77%   -0.02%     
==========================================
  Files         162      162              
  Lines        9832     9863      +31     
==========================================
+ Hits         7452     7474      +22     
- Misses       2380     2389       +9     
Impacted Files Coverage Δ
beater/http.go 66.66% <40.00%> (-1.67%) ⬇️
beater/server.go 66.10% <72.00%> (+0.31%) ⬆️
beater/jaeger/server.go 81.81% <100.00%> (+1.81%) ⬆️
...ack/apm-server/aggregation/txmetrics/aggregator.go 93.36% <0.00%> (ø)

@axw axw merged commit 905b906 into elastic:7.x Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants