Update beats framework, fix bug in template setup cmd, remove host.name. #1934
Merged
simitt merged 4 commits intoelastic:masterfrom Feb 20, 2019
Merged
Update beats framework, fix bug in template setup cmd, remove host.name. #1934simitt merged 4 commits intoelastic:masterfrom
template setup cmd, remove host.name. #1934simitt merged 4 commits intoelastic:masterfrom
Conversation
18f275c to
295e42b
Compare
graphaelli
approved these changes
Feb 15, 2019
Member
graphaelli
left a comment
There was a problem hiding this comment.
the beats update looks good, left comments on the template setup tests in #1935
0e1348f to
487cbe3
Compare
template setup cmd template setup cmd, remove host.name.
Contributor
Author
|
@graphaelli since this update also includes the I rebased the branch to organize the commits as they should be merged (with a rebase & merge). |
487cbe3 to
faf3b20
Compare
Add tests for template setup. fixes elastic#1922
fc0f947 to
66de8b3
Compare
Contributor
Author
|
@graphaelli I changed this after your approval, could you please re-review. |
graphaelli
approved these changes
Feb 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1922
fixes #1846