feat: add support for APM Agent Configuration via Kibana#66
feat: add support for APM Agent Configuration via Kibana#66Qard merged 10 commits intoelastic:masterfrom
Conversation
|
Wrote a small test program to test this based on the dev setup described in elastic/apm#76 (comment): const Client = require('elastic-apm-http-client')
const client = new Client({
serviceName: 'opbeans-fortran',
agentName: 'my-nodejs-agent',
agentVersion: '1.0.0',
userAgent: 'My Custom Elastic APM Agent',
remoteConfig: true
})
client.on('config', function (conf) {
console.log('new config:', conf)
})
client.on('request-error', function (err) {
console.log('request-error:', err)
})
setTimeout(function () {}, 100000) // don't exit the processThis was the console output: |
df2a5a2 to
42a4fdf
Compare
|
@Qard just added two commits, the primary one to just add a notice about required APM Server version Update: Had to revert that last commit, as default function args doesn't work exactly how falsy values does. In our case, there's a risk at the number of seconds given is |
|
... aaand another one. Just found a "typo" in the new docs that I wanted to fix. |
|
I just updated the PR with the latest updates from elastic/apm#76:
It also seems like we're going to decide to have this feature enabled by default. I still think we should leave it off by default in the http client, no matter if we end up turning it on by default in the agent. This will allow us to release this PR to npm as a minor bump in good time before 7.3 without worrying about anything. |
There was a problem hiding this comment.
Just did a fresh review and this still seems correct, as far as I can tell. The config option appears to be not happening though, so unsure if we should unify by removing it or just leave the un-unified config in there as we generally just focus on config unification at the agent level. Personally, I like having this escape hatch here in case we need it later. 🤔
@felixbarny @axw Thoughts?
This reverts commit 5a546fc.
HTTP client part of elastic/apm-agent-nodejs#1125.