Skip to content
This repository was archived by the owner on Jan 23, 2024. It is now read-only.

Commit 89f1a05

Browse files
v1vmergify-bot
authored andcommitted
apm: Neutral naming for apm-agent-java (#1375)
(cherry picked from commit 5385134) # Conflicts: # README.md
1 parent 767c739 commit 89f1a05

5 files changed

Lines changed: 30 additions & 5 deletions

File tree

README.md

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,7 @@ These are the scripts available to execute:
273273
It is possible to configure some options and versions to run by defining environment variables before to launch the scripts
274274

275275
* `COMPOSE_ARGS`: replaces completely the default arguments compose.py used by scripts, see the compose.py help to know which ones you can use.
276+
<<<<<<< HEAD
276277
* `DISABLE_BUILD_PARALLEL`: by default Docker images are built in parallel, if you set `DISABLE_BUILD_PARALLEL=true` the Docker images will build in serie. It helps to make the logs more readable.
277278
* `BUILD_OPTS`: aggregates arguments to default arguments passing to compose.py see the compose.py help to know which ones you can use.
278279
* `ELASTIC_STACK_VERSION`: selects the Elastic Stack version to use on tests, by default is is used the master branch. You can choose any branch or tag from the Github repo.
@@ -283,6 +284,30 @@ It is possible to configure some options and versions to run by defining environ
283284
* `APM_AGENT_NODEJS_VERSION`: selects the agent Nodejs version to use, by default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
284285
* `APM_AGENT_PYTHON_VERSION`: selects the agent Python version to use, by default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
285286
* `APM_AGENT_RUBY_VERSION`: selects the agent Ruby version to use, by default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
287+
=======
288+
289+
* `DISABLE_BUILD_PARALLEL`: by default Docker images are built in parallel. If you set `DISABLE_BUILD_PARALLEL=true` then the Docker images will build in series, which helps to make the logs more readable.
290+
291+
* `BUILD_OPTS`: aggregates arguments to default arguments passing to compose.py. See `compose.py` help to know which ones you can use.
292+
293+
* `ELASTIC_STACK_VERSION`: selects the Elastic Stack version to use on tests. By default is is used the master branch. You can choose any branch or tag from the Github repo.
294+
295+
* `APM_SERVER_BRANCH`: selects the APM Server version to use on tests. By default it uses the master branch. You can choose any branch or tag from the Github repo.
296+
297+
* `APM_AGENT_DOTNET_VERSION`: selects the agent .NET version to use. By default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
298+
299+
* `APM_AGENT_GO_VERSION`: selects the agent Go version to use. By default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
300+
301+
* `APM_AGENT_JAVA_VERSION`: selects the agent Java version to use. By default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
302+
303+
* `APM_AGENT_NODEJS_VERSION`: selects the agent Nodejs version to use. By default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
304+
305+
* `APM_AGENT_PHP_VERSION`: selects the agent PHP version to use. By default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
306+
307+
* `APM_AGENT_PYTHON_VERSION`: selects the agent Python version to use. By default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
308+
309+
* `APM_AGENT_RUBY_VERSION`: selects the agent Ruby version to use. By default it uses the main branch. See [specify an agent version](#specify-an-agent-version)
310+
>>>>>>> 5385134 (apm: Neutral naming for apm-agent-java (#1375))
286311
287312
#### Specify an Agent Version
288313

docker/java/spring/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
FROM maven:3.6.3-adoptopenjdk-11
22

33
ARG JAVA_AGENT_REPO=elastic/apm-agent-java
4-
ARG JAVA_AGENT_BRANCH=master
4+
ARG JAVA_AGENT_BRANCH=main
55
ARG JAVA_AGENT_BUILT_VERSION=
66
ARG JAVA_M2_CACHE=false
77

scripts/modules/apm_agents.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ def _content(self):
460460

461461
class AgentJavaSpring(Service):
462462
SERVICE_PORT = 8090
463-
DEFAULT_AGENT_VERSION = "master"
463+
DEFAULT_AGENT_VERSION = "main"
464464
DEFAULT_AGENT_RELEASE = ""
465465
DEFAULT_AGENT_REPO = "elastic/apm-agent-java"
466466

@@ -470,7 +470,7 @@ def add_arguments(cls, parser):
470470
parser.add_argument(
471471
"--java-agent-version",
472472
default=cls.DEFAULT_AGENT_VERSION,
473-
help='Use Java agent version (master, 0.5, v.0.7.1, ...)',
473+
help='Use Java agent version (main, 0.5, v.0.7.1, ...)',
474474
)
475475
parser.add_argument(
476476
"--java-agent-release",

scripts/tests/test_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ def test_agent_java_spring(self):
318318
agent-java-spring:
319319
build:
320320
args:
321-
JAVA_AGENT_BRANCH: master
321+
JAVA_AGENT_BRANCH: main
322322
JAVA_AGENT_BUILT_VERSION: ""
323323
JAVA_AGENT_REPO: elastic/apm-agent-java
324324
JAVA_M2_CACHE: "false"

tests/versions/java.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
JAVA_AGENT:
2-
- 'github;master'
2+
- 'github;main'
33
- 'release;1.19.0'
44
- 'release;1.18.1'

0 commit comments

Comments
 (0)