Skip to content

Support TraceContext and tracestate#694

Merged
mikker merged 12 commits intoelastic:masterfrom
mikker:trace-context
Feb 5, 2020
Merged

Support TraceContext and tracestate#694
mikker merged 12 commits intoelastic:masterfrom
mikker:trace-context

Conversation

@mikker
Copy link
Copy Markdown
Contributor

@mikker mikker commented Jan 21, 2020 •
edited
Loading

Closes #621.
See elastic/apm#71 for details.

@mikker mikker self-assigned this Jan 21, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 22, 2020 •
edited
Loading

Codecov Report

Merging #694 into master will decrease coverage by 0.02%.
The diff coverage is 59.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
- Coverage   64.18%   64.16%   -0.03%     
==========================================
  Files          99      101       +2     
  Lines        2971     3022      +51     
==========================================
+ Hits         1907     1939      +32     
- Misses       1064     1083      +19
Impacted Files Coverage Δ
lib/elastic_apm/agent.rb 84.53% <ø> (ø) ⬆️
lib/elastic_apm/middleware.rb 34.28% <0%> (+0.95%) ⬆️
lib/elastic_apm/spies/faraday.rb 23.52% <0%> (ø) ⬆️
lib/elastic_apm/spies/net_http.rb 39.47% <0%> (ø) ⬆️
lib/elastic_apm/spies/http.rb 50% <0%> (ø) ⬆️
lib/elastic_apm/config.rb 73.75% <100%> (+0.16%) ⬆️
lib/elastic_apm/trace_context.rb 55.55% <48.38%> (-12.74%) ⬇️
lib/elastic_apm/trace_context/traceparent.rb 69.56% <69.56%> (ø)
lib/elastic_apm/trace_context/tracestate.rb 70% <70%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1538a80...fbf1fbe. Read the comment docs.

@mikker
Copy link
Copy Markdown
Contributor Author

mikker commented Jan 22, 2020

Spec error is one of the usual unrelated jruby ones.

@mikker mikker requested a review from estolfo January 22, 2020 12:42
@mikker mikker added this to the 7.6 milestone Jan 22, 2020
@mikker mikker marked this pull request as ready for review January 22, 2020 12:42
@zube zube bot removed this from the 7.6 milestone Jan 22, 2020
estolfo
estolfo reviewed Jan 23, 2020
View reviewed changes
@mikker
Copy link
Copy Markdown
Contributor Author

mikker commented Jan 24, 2020

I pulled out Traceparent into its own class. TraceContext is referred to quite a few places and is sort of in a gray area public api-wise. Hence there's some redirection from context to -parent.

@mikker mikker requested a review from estolfo January 24, 2020 11:42
estolfo
estolfo reviewed Jan 27, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@estolfo estolfo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

I think the design now makes a lot of sense and more easily allows for future additions/extensions. Thanks!

mikker
mikker commented Feb 5, 2020
View reviewed changes
@mikker mikker merged commit 85f1185 into elastic:master Feb 5, 2020
@mikker mikker deleted the trace-context branch February 5, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estolfo estolfo estolfo left review comments

Assignees

@mikker mikker

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fully support TraceContext

3 participants

@mikker @codecov-io @estolfo