added async_capture_span for decorating coroutines and async with#657
Merged
beniwohli merged 5 commits intoelastic:masterfrom Nov 29, 2019
Merged
added async_capture_span for decorating coroutines and async with#657beniwohli merged 5 commits intoelastic:masterfrom
async with#657beniwohli merged 5 commits intoelastic:masterfrom
Conversation
afe7a8a to
1287d28
Compare
axw
approved these changes
Nov 29, 2019
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
It adds a new API,
async_capture_span, which can be used to decoratecoroutines and asynchronous context managers (
async with).Additionally, it adds instrumentation for
asyncio.tasks.sleep.Why is it important?
Providing these APIs allows ourselves and our users to instrument
asynchronous applications.
Related issues
refs #598