move processors to run on background processing thread#607
Merged
beniwohli merged 12 commits intoelastic:masterfrom Nov 26, 2019
Merged
move processors to run on background processing thread#607beniwohli merged 12 commits intoelastic:masterfrom
beniwohli merged 12 commits intoelastic:masterfrom
Conversation
processing can be somewhat heavey, moving it out of the main thread should help with overhead. This is the first step to move source code collection onto the background thread. The next step will be to turn the current source code collection into a processor.
6cbcd8e to
bb879da
Compare
6 tasks
this moves the last bit of blocking code out of the main thread, opening the door a bit further for asyncio support
Contributor
Author
|
@basepi can you have another look at this one? Would love to hear your opinion specifically on the new processor and how the hardcoded processors work |
basepi
reviewed
Nov 15, 2019
Contributor
basepi
left a comment
There was a problem hiding this comment.
Overall this looks good, couple of comments below.
(Oh, and sorry for the pre-completion initial review -- from now on I'm waiting until you request my review. :) )
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processing can be somewhat heavey, moving it out of the main thread
should help with overhead.
This is the first step to move source code collection onto the background
thread. The next step will be to turn the current source code collection
into a processor.