Skip to content

[Azure Tables] Check if request body exists before trying to convert it to JSON#2119

Closed
cpiment wants to merge 9 commits intoelastic:mainfrom
cpiment:main
Closed

[Azure Tables] Check if request body exists before trying to convert it to JSON#2119
cpiment wants to merge 9 commits intoelastic:mainfrom
cpiment:main

Conversation

@cpiment
Copy link
Copy Markdown
Contributor

@cpiment cpiment commented Sep 5, 2024

What does this pull request do?

Checks existence of body payload in request to Azure Table service before trying to convert it into JSON, thus avoiding TypeError

Related issues

Closes #2118

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Sep 5, 2024
xrmx
xrmx reviewed Sep 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Needs a test in tests/contrib/serverless/azurefunctions/azure_functions_tests.py to avoid regressions in the future

@cpiment
Copy link
Copy Markdown
Contributor Author

cpiment commented Sep 6, 2024

Hi @xrmx , I'm developing the tests, but I have realized that the problem is that I'm using the new Python library for Azure Tables (package azure-data-tables) but the tests are done using the deprecated library (azure-cosmosdb-tables package). The deprecation warning is in the new package documentation: azure-data-tables

Should I keep tests for both libraries in tests/instrumentation/azure_tests.py? Or should I just remove the code that refers to azure-cosmosdb-tables?

@xrmx
Copy link
Copy Markdown
Member

xrmx commented Sep 6, 2024

Hi @xrmx , I'm developing the tests, but I have realized that the problem is that I'm using the new Python library for Azure Tables (package azure-data-tables) but the tests are done using the deprecated library (azure-cosmosdb-tables package). The deprecation warning is in the new package documentation: azure-data-tables

Interesting

Should I keep tests for both libraries in tests/instrumentation/azure_tests.py? Or should I just remove the code that refers to azure-cosmosdb-tables?

tests for cosmosdb need to be kept

@cpiment
Copy link
Copy Markdown
Contributor Author

cpiment commented Sep 6, 2024

Hi @xrmx, I have just pushed the requested changes. Thanks for your help

@cpiment
Copy link
Copy Markdown
Contributor Author

cpiment commented Sep 11, 2024

Hi @xrmx, have you had time to review the changes? I'm thinking maybe the PR should be renamed to "Support for azure-data-tables", what do you think?

Thanks for your help.

@cpiment
Copy link
Copy Markdown
Contributor Author

cpiment commented Oct 22, 2024

Hi @xrmx, do you need anything else by my side? Is there any way I can help to make this change to be reviewed and (hopefully) merged?

@k-tratseuski
Copy link
Copy Markdown

k-tratseuski commented Dec 11, 2024

Any updates on this?

xrmx
xrmx reviewed Dec 24, 2024
View reviewed changes
xrmx
xrmx reviewed Dec 24, 2024
View reviewed changes
@xrmx xrmx self-assigned this Jul 8, 2025
@xrmx xrmx mentioned this pull request Jul 9, 2025
Merged
@xrmx xrmx closed this in #2187 Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx left review comments

Assignees

@xrmx xrmx

Labels

agent-python community Issues opened by the community triage Issues awaiting triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

APM-Instrumented Azure Function crashes when querying to Azure Table

3 participants

@cpiment @xrmx @k-tratseuski