Skip to content

implement dropping of fast exit spans#1418

Merged
beniwohli merged 7 commits intoelastic:masterfrom
beniwohli:drop-fast-exit-spans
Dec 1, 2021
Merged

implement dropping of fast exit spans#1418
beniwohli merged 7 commits intoelastic:masterfrom
beniwohli:drop-fast-exit-spans

Conversation

@beniwohli
Copy link
Copy Markdown
Contributor

@beniwohli beniwohli commented Nov 29, 2021

closes #1309

beniwohli
beniwohli commented Nov 29, 2021
View reviewed changes
tests/instrumentation/transactions_store_tests.py
events[event_type].append(event)

store = Tracer(lambda: frames, lambda frames: frames, queue, Config(), None)
store = Tracer(lambda: frames, lambda frames: frames, queue, elasticapm_client.config, elasticapm_client)
Copy link
Copy Markdown
Contributor Author

@beniwohli beniwohli Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change was needed so that the tests that use this fixture also respect the default settings we set up in the elasticapm_client fixture

@ghost
Copy link
Copy Markdown

ghost commented Nov 29, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-01T14:23:00.098+0000

  • Duration: 34 min 47 sec

  • Commit: 76a6cc1

Test stats 🧪

Test Results
Failed 0
Passed 10269
Skipped 9579
Total 19848

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@beniwohli beniwohli requested a review from basepi November 29, 2021 16:35
basepi
basepi approved these changes Nov 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@basepi basepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a hunch this was where the conversation about adding microseconds happened, so I checked the spec and added one note below. Otherwise looks great!

@beniwohli beniwohli merged commit 6bc96be into elastic:master Dec 1, 2021
@beniwohli beniwohli deleted the drop-fast-exit-spans branch December 1, 2021 15:31
@basepi basepi mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basepi basepi basepi approved these changes

Assignees

No one assigned

Labels

agent-python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[META 496] Dropping fast exit spans

4 participants

@beniwohli @basepi @elastic-apm-tech @mdelapenya