Merged
Conversation
3a6744b to
cfa106c
Compare
ruflin
approved these changes
Aug 29, 2017
Contributor
ruflin
left a comment
There was a problem hiding this comment.
Left some minor comments which I think can also be adressed later. I suggest to merge this as is.
| ) | ||
| ---- | ||
|
|
||
| 1. Choose an app name, and set the secret token if needed. |
Contributor
There was a problem hiding this comment.
In the future we should link there to what is allowed for app names and what not, but first we need a doc for it.
| ==== Instrumenting custom Python code | ||
|
|
||
| To gain further insights into the performance of your code, please see | ||
| <<./custom-instrumentation.asciidoc#instrumenting-custom-code, instrumenting custom code>>. |
Contributor
There was a problem hiding this comment.
This should work, but normally you should be able to just use the reference. @dedemorton ?
| ) | ||
| ---- | ||
|
|
||
| the "Extra" tab on detail page for the error group will now have the extra field `datetime`. |
Contributor
There was a problem hiding this comment.
Not sure if I would reference here the UI as the UI could change independent.
|
|
||
| [source,bash] | ||
| ---- | ||
| python manage.py elasticapm test |
6179ff2 to
32aece2
Compare
32aece2 to
e9d8e7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.