Skip to content

Remote config#640

Merged
felixbarny merged 10 commits intoelastic:masterfrom
felixbarny:central-configuration
Jul 17, 2019
Merged

Remote config#640
felixbarny merged 10 commits intoelastic:masterfrom
felixbarny:central-configuration

Conversation

@felixbarny
Copy link
Copy Markdown
Member

@felixbarny felixbarny commented May 21, 2019 •
edited
Loading

closes #636

@jalvz jalvz mentioned this pull request May 21, 2019
Closed
7 tasks
@felixbarny felixbarny self-assigned this May 24, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 28, 2019 •
edited
Loading

Codecov Report

Merging #640 into master will increase coverage by 0.23%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #640      +/-   ##
===========================================
+ Coverage     66.67%   66.9%   +0.23%     
- Complexity       85      86       +1     
===========================================
  Files           209     209              
  Lines          9356    9515     +159     
  Branches       1329    1336       +7     
===========================================
+ Hits           6238    6366     +128     
- Misses         2774    2795      +21     
- Partials        344     354      +10
Impacted Files Coverage Δ Complexity Δ
...lastic/apm/agent/report/ReporterConfiguration.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...pm/agent/report/IntakeV2ReportingEventHandler.java 79.77% <0%> (-1.82%) 0 <0> (ø)
.../quartz/job/JobTransactionNameInstrumentation.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...apm/agent/quartz/job/JobTransactionNameAdvice.java 4.16% <4.16%> (ø) 0 <0> (ø) ⬇️
...ic/apm/agent/slf4j/Slf4JMdcActivationListener.java 89.13% <76.92%> (+11.08%) 0 <0> (ø) ⬇️
...iguration/PrefixingConfigurationSourceWrapper.java 41.66% <0%> (-16.67%) 0% <0%> (ø)
...stic/apm/agent/jdbc/signature/SignatureParser.java 91.48% <0%> (-2.89%) 0% <0%> (ø)
...va/co/elastic/apm/agent/impl/ElasticApmTracer.java 74.57% <0%> (-2.41%) 0% <0%> (-14%)
...astic/apm/agent/report/ApmServerHealthChecker.java 54.54% <0%> (-1.82%) 0% <0%> (ø)
...astic/apm/agent/impl/transaction/TraceContext.java 88.34% <0%> (-1.8%) 18% <0%> (+18%)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7865146...63f25f6. Read the comment docs.

@jalvz
Copy link
Copy Markdown

jalvz commented May 28, 2019

depends on elastic/apm-server#2095

@felixbarny felixbarny marked this pull request as ready for review June 18, 2019 14:27
eyalkoren
eyalkoren reviewed Jun 27, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

The recent decision to enable polling configuration on the APM server requires some changes. Not a big deal.

In addition, I think we need to see how we make this fit with the healthcheck, retrying with different servers etc.

@felixbarny felixbarny mentioned this pull request Jul 16, 2019
Closed
eyalkoren
eyalkoren reviewed Jul 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Very good comments and tests!
Few minor comments.

apm-agent-core/src/main/java/co/elastic/apm/agent/report/ApmServerClient.java Outdated
throw previousException;
}

public void executeForAllUrls(String path, ConnectionHandler<Void> connectionHandler) throws Exception {
Copy link
Copy Markdown
Contributor

@eyalkoren eyalkoren Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to reuse common code with execute

Copy link
Copy Markdown
Member Author

@felixbarny felixbarny Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new changes, the logic is quite different now.

@felixbarny felixbarny merged commit 8aaaf6a into elastic:master Jul 17, 2019
@felixbarny felixbarny deleted the central-configuration branch July 17, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eyalkoren eyalkoren eyalkoren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@felixbarny felixbarny

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remote config

4 participants

@felixbarny @codecov-io @jalvz @eyalkoren