Skip to content

Add option elasticsearch capture body urls#3091

Merged
jackshirazi merged 6 commits intoelastic:mainfrom
jackshirazi:add-option-elasticsearch-capture-body-urls
Apr 3, 2023
Merged

Add option elasticsearch capture body urls#3091
jackshirazi merged 6 commits intoelastic:mainfrom
jackshirazi:add-option-elasticsearch-capture-body-urls

Conversation

@jackshirazi
Copy link
Copy Markdown
Contributor

@jackshirazi jackshirazi commented Mar 31, 2023 •
edited
Loading

What does this PR do?

Per the spec this adds the elasticsearch_capture_body_urls option

Note that I've changed the category of the Mongo documentation from MongoDB to Datastore (which is also used for this ES option) following a team discussion that decided this was a better category. That means the existing MongoDB URL will no longer work and anything linking to it will get a 404. I decided this is better rather than making the MongoDB category a redirect page as it was a very niche option and we don't need the extra clutter for such a niche option

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@jackshirazi jackshirazi requested a review from a team March 31, 2023 16:49
@jackshirazi jackshirazi linked an issue Mar 31, 2023 that may be closed by this pull request
[META 672] Add option for when to capture the Elasticsearch query #2745
Closed
@ghost
Copy link
Copy Markdown

ghost commented Mar 31, 2023 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-04-03T11:12:08.874+0000

  • Duration: 14 min 57 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

SylvainJuge
SylvainJuge approved these changes Apr 3, 2023
View reviewed changes
@jackshirazi @SylvainJuge
Update CHANGELOG.asciidoc
fb22b28 
Co-authored-by: SylvainJuge <syl20j@gmail.com>
@jackshirazi jackshirazi merged commit be3870b into elastic:main Apr 3, 2023
@SylvainJuge SylvainJuge mentioned this pull request Apr 12, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SylvainJuge SylvainJuge SylvainJuge approved these changes

Assignees

No one assigned

Labels

agent-java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[META 672] Add option for when to capture the Elasticsearch query

3 participants

@jackshirazi @SylvainJuge @elastic-apm-tech