implementation for Trace Continuation Strategy#2760
Merged
jackshirazi merged 12 commits intoelastic:mainfrom Sep 7, 2022
Merged
implementation for Trace Continuation Strategy#2760jackshirazi merged 12 commits intoelastic:mainfrom
jackshirazi merged 12 commits intoelastic:mainfrom
Conversation
felixbarny
reviewed
Aug 29, 2022
Member
felixbarny
left a comment
There was a problem hiding this comment.
Looks good 👏
Just a couple of small suggestions
…tion/Transaction.java Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
…n/CoreConfiguration.java Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
Generics improvements
felixbarny
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements Trace Continuation Strategy per https://github.com/elastic/apm/blob/main/specs/agents/trace-continuation.md
Note for reviewers. The choice of Transaction.onTransactionStart() as the sole location to apply the strategy is because
the span for adding span links, so the options were to
1a. Reimplement all the trace context header handling to enable that or
1b. Move up the stack - which is what I chose
2a ExternalSpanContextInstrumentation.parseTextMap is for reading headers only, so can be ignored
2b JmsInstrumentationHelper.makeChildOf which uses JMS headers so I've assumed that the strategy doesn't apply here (THIS MAY BE AN INCORRECT ASSUMPTION)
Checklist