Skip to content

Update to transaction_ignore_urls config name#1315

Merged
eyalkoren merged 2 commits intoelastic:masterfrom
eyalkoren:ignore-urls-new-name
Jul 29, 2020
Merged

Update to transaction_ignore_urls config name#1315
eyalkoren merged 2 commits intoelastic:masterfrom
eyalkoren:ignore-urls-new-name

Conversation

@eyalkoren
Copy link
Copy Markdown
Contributor

@eyalkoren eyalkoren commented Jul 28, 2020 •
edited
Loading

Closes #1313

@felixbarny I believe all we are required to do is renaming, while still allowing the old name so it is not a breaking change, right?
cc @gregkalapos 🙂

gregkalapos
gregkalapos reviewed Jul 28, 2020
View reviewed changes
apm-agent-core/src/main/java/co/elastic/apm/agent/impl/context/web/WebConfiguration.java
.builder(new ListValueConverter<>(new WildcardMatcherValueConverter()), List.class)
.key("ignore_urls")
.key("transaction_ignore_urls")
.aliasKeys("ignore_urls")
Copy link
Copy Markdown
Contributor

@gregkalapos gregkalapos Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, you can even do an alias in your config-system; very fancy! 👏 👏

Copy link
Copy Markdown
Contributor Author

@eyalkoren eyalkoren Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we use a fancy third party for that 😉

Copy link
Copy Markdown
Member

@felixbarny felixbarny Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it a 2.5 party 😛

@ghost
Copy link
Copy Markdown

ghost commented Jul 28, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #1315 opened]

  • Start Time: 2020-07-28T15:10:06.000+0000

  • Duration: 47 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 1425
Skipped 11
Total 1436

felixbarny
felixbarny approved these changes Jul 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a changelog, otherwise LGTM

@eyalkoren eyalkoren merged commit fa298cc into elastic:master Jul 29, 2020
@eyalkoren eyalkoren deleted the ignore-urls-new-name branch July 29, 2020 04:51
@ghost
Copy link
Copy Markdown

ghost commented Jul 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #1315 updated]

  • Start Time: 2020-07-29T04:34:46.463+0000

  • Duration: 44 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 1425
Skipped 11
Total 1436

Steps errors

Expand to view the steps failures

  • Name: Download Codecov

    • Description: #!/bin/bash set -x curl -sSLo codecov.sh https://codecov.io/bash

    • Duration: 2 min 22 sec

    • Start Time: 2020-07-29T04:55:23.244+0000

    • log

@felixbarny
Copy link
Copy Markdown
Member

felixbarny commented Sep 1, 2020

@eyalkoren could you create a changelog for this?

@eyalkoren
Copy link
Copy Markdown
Contributor Author

eyalkoren commented Sep 2, 2020

could you create a changelog for this?

@felixbarny it was added before merging. You probably looked at the RC release notes and not the unreleased

@felixbarny
Copy link
Copy Markdown
Member

felixbarny commented Sep 2, 2020

ah, right 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregkalapos gregkalapos gregkalapos left review comments

@felixbarny felixbarny felixbarny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add TRANSACTION_IGNORE_URLS option

3 participants

@eyalkoren @felixbarny @gregkalapos