Skip to content

Fix javadoc error on Java 11#1237

Merged
felixbarny merged 1 commit intoelastic:masterfrom
felixbarny:javadoc-java-11-error
Jun 16, 2020
Merged

Fix javadoc error on Java 11#1237
felixbarny merged 1 commit intoelastic:masterfrom
felixbarny:javadoc-java-11-error

Conversation

@felixbarny
Copy link
Copy Markdown
Member

@felixbarny felixbarny commented Jun 16, 2020 •
edited by zube bot
Loading

Prerequisite for #1236

@felixbarny felixbarny mentioned this pull request Jun 16, 2020
Merged
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 16, 2020

Codecov Report

Merging #1237 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1237      +/-   ##
============================================
- Coverage     59.36%   59.34%   -0.02%     
  Complexity       87       87              
============================================
  Files           354      354              
  Lines         16270    16270              
  Branches       2269     2269              
============================================
- Hits           9658     9655       -3     
- Misses         5953     5958       +5     
+ Partials        659      657       -2
Impacted Files Coverage Δ Complexity Δ
...pm/agent/profiler/asyncprofiler/AsyncProfiler.java 60.46% <0.00%> (-4.66%) 0.00% <0.00%> (ø%)
...o/elastic/apm/agent/profiler/SamplingProfiler.java 71.57% <0.00%> (-0.26%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9c5e4...9e284df. Read the comment docs.

@ghost
Copy link
Copy Markdown

ghost commented Jun 16, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #1237 opened]

  • Start Time: 2020-06-16T11:09:41.445+0000

  • Duration: 37 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 1379
Skipped 11
Total 1390

eyalkoren
eyalkoren approved these changes Jun 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all it took? Nice!

@felixbarny felixbarny merged commit 6f482fa into elastic:master Jun 16, 2020
@felixbarny felixbarny deleted the javadoc-java-11-error branch June 16, 2020 12:35
@eyalkoren eyalkoren mentioned this pull request Jul 16, 2020
Merged
6 tasks
@felixbarny felixbarny mentioned this pull request Aug 26, 2020
Merged
5 tasks
@SylvainJuge
Copy link
Copy Markdown
Member

SylvainJuge commented Aug 26, 2020

For the record, switching to java11 from java 10 for build also requires to add <detectJavaApiLink>false</detectJavaApiLink> (e988686) to make it work, otherwise we still get the following error:

Exit code: 1 - javadoc: error - The code being documented uses packages in the unnamed module, but the packages defined in https://docs.oracle.com/en/java/javase/11/docs/api/ are in named modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eyalkoren eyalkoren eyalkoren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@felixbarny @codecov-commenter @SylvainJuge @eyalkoren