Skip to content

docs: add mentions of central config#598

Merged
axw merged 1 commit intoelastic:masterfrom
axw:central-config-docs
Jul 31, 2019
Merged

docs: add mentions of central config#598
axw merged 1 commit intoelastic:masterfrom
axw:central-config-docs

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented Jul 25, 2019

Add mentions of central config:

  • Order of precedence
  • ELASTIC_APM_CENTRAL_CONFIG config

Splitting this out of #591, so we can land that PR and let it soak a bit while we wait for the server docs to be updated.

@axw
Copy link
Copy Markdown
Member Author

axw commented Jul 25, 2019

Must not be merged until the server docs are updated.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jul 25, 2019

Codecov Report

Merging #598 into master will increase coverage by 0.07%.
The diff coverage is 88.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
+ Coverage    87.7%   87.77%   +0.07%     
==========================================
  Files         121      122       +1     
  Lines        7255     7470     +215     
==========================================
+ Hits         6363     6557     +194     
- Misses        794      813      +19     
- Partials       98      100       +2
Impacted Files Coverage Δ
breakdown.go 95.89% <ø> (-0.17%) ⬇️
apmtest/withtransaction.go 100% <100%> (+7.14%) ⬆️
module/apmgrpc/client.go 97.29% <100%> (+1%) ⬆️
apmtest/configwatcher.go 100% <100%> (ø)
transaction.go 97.5% <100%> (ø) ⬆️
tracer.go 89.69% <77.55%> (-1.93%) ⬇️
env.go 83.33% <90.9%> (+0.92%) ⬆️
apmtest/recorder.go 90.47% <91.66%> (+1.58%) ⬆️
transport/http.go 94.27% <95.34%> (-0.07%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78acc5...9cec8b5. Read the comment docs.

@axw axw closed this Jul 31, 2019
@axw axw reopened this Jul 31, 2019
@zube zube bot closed this Jul 31, 2019
@zube zube bot reopened this Jul 31, 2019
@zube zube bot closed this Jul 31, 2019
@zube zube bot reopened this Jul 31, 2019
@zube zube bot closed this Jul 31, 2019
@zube zube bot reopened this Jul 31, 2019
- Order of precedence
- ELASTIC_APM_CENTRAL_CONFIG config
@axw axw force-pushed the central-config-docs branch from 9cec8b5 to 23a3553 Compare July 31, 2019 22:51
@axw axw merged commit 245fbdc into elastic:master Jul 31, 2019
@axw axw deleted the central-config-docs branch July 31, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants