Change 'cloud.project.id' for GCP metadata to be the 'project-id'#2180
Merged
Mpdreamz merged 1 commit intoelastic:mainfrom Sep 12, 2023
Merged
Conversation
Mpdreamz
approved these changes
Sep 11, 2023
Member
Mpdreamz
left a comment
There was a problem hiding this comment.
This LGTM, any reason this is still a draft? Looks complete to me :)
Member
Author
Because I was still struggling to run tests locally (see my Q in slack). :) Also I wasn't sure if I should be adding a changelog entry. |
Member
CI happy == me happy 😸
Nope! Thanks for submitting a fix and welcome to the world of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2177