Update log level based on central configuration and support "off" configuration#1096
Merged
russcam merged 3 commits intoelastic:masterfrom Dec 22, 2020
Merged
Conversation
This commit updates the log level of the configured IApmLogger based on the log level received from central configuration. An ILogLevelSwitchable interface is introduced that can be implemented by an IApmLogger to allow the log level to be updated by central configuration. ConsoleLogger implements ILogLevelSwitchable but NetCoreLogger does not. The ability to change the log level of NetCoreLogger at runtime is controlled by the provider used with Microsoft.Extensions.Logging. Closes elastic#970
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Contributor
Author
|
jenkins please run the tests |
gregkalapos
approved these changes
Dec 21, 2020
test/Elastic.Apm.Tests/BackendCommTests/CentralConfig/CentralConfigFetcherTests.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows updating the log level of the configured
IApmLoggerat runtime, based on the log level received from central configuration, and also supports the "off" central configuration log level.An
ILogLevelSwitchableinterface is introduced that can be implemented by anIApmLoggerto allow the log level to be updated by central configuration.ConsoleLoggerimplementsILogLevelSwitchablebutNetCoreLoggerdoes not. The ability to change the log level ofNetCoreLoggerat runtime is controlled by the provider used with Microsoft.Extensions.Logging.Closes #970