Merged
Conversation
This commit adds the fetching of cloud metadata to the agent, to send as part of the agent metadata when an agent is running in a Cloud provider. On starting the payload sender's work loop, the first iteration will asynchronously fetch the metadata for the cloud provider specified with the ELASTIC_APM_CLOUD_PROVIDER env var, or the ElasticApm:CloudProvider app setting. Values are aws, gcp, azure and false. When false is specified, no cloud metadata providers are registered, so there are no attempts to fetch metadata. The default value of null or "" will attempt to fetch metadata using all registered providers. Closes elastic#918
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
Log outputExpand to view the last 100 lines of log output
|
Contributor
Author
|
jenkins run the tests please |
Contributor
Author
|
Will follow up in a separate PR for retrieving metadata for Azure App Services |
gregkalapos
approved these changes
Nov 9, 2020
Contributor
gregkalapos
left a comment
There was a problem hiding this comment.
Nice, LGTM!
I left 1 comment regarding printing warnings - definitely not a blocker, it's for consideration.
| } | ||
| catch (Exception e) | ||
| { | ||
| _logger.Warning()?.LogException(e, "Unable to get {Provider} cloud metadata", Provider); |
Contributor
There was a problem hiding this comment.
Sure about the Warning level? Given the default for this setting is to try all ICloudMetadataProvider implementations, the agent will start with 3 warnings in non-cloud and with 2 if it runs in one of the cloud providers.
I feel we should use info here.
We have a similar situation with the central config fetcher and I see people are very confused about those warnings as well.
Contributor
Author
There was a problem hiding this comment.
Will change to info - agree that warning seems way too strong
bmorelli25
approved these changes
Nov 9, 2020
Member
bmorelli25
left a comment
There was a problem hiding this comment.
Same comment as Greg, otherwise docs LG
Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Contributor
Author
|
jenkins run the tests please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates: elastic/apm#256
This commit adds the fetching of cloud metadata to
the agent, to send as part of the agent metadata
when an agent is running in a Cloud provider.
On starting the payload sender's work loop,
the first iteration will asynchronously fetch
the metadata for the cloud provider specified with
the ELASTIC_APM_CLOUD_PROVIDER env var, or the
ElasticApm:CloudProvider app setting. Values
are aws, gcp, azure and false. When false is
specified, no cloud metadata providers are
registered, so there are no attempts to fetch
metadata. The default value of null or ""
will attempt to fetch metadata using all registered
providers.
Closes #918