Skip to content

Add CgroupMetricsProvider#1000

Merged
russcam merged 6 commits intoelastic:masterfrom
russcam:feature/cgroup-metrics
Nov 10, 2020
Merged

Add CgroupMetricsProvider#1000
russcam merged 6 commits intoelastic:masterfrom
russcam:feature/cgroup-metrics

Conversation

@russcam
Copy link
Copy Markdown
Contributor

@russcam russcam commented Oct 30, 2020 •
edited by zube bot
Loading

This commit adds a CgroupMetricsProvider to collect cgroup metrics.

Tests use test files and directory structure from the APM Java agent

Closes #937

@russcam
Add CgroupMetricsProvider
0342847 
This commit adds a CgroupMetricsProvider to collect cgroup metrics.

Tests use test files and directory structure from the APM Java agent

Closes elastic#937
@russcam russcam requested a review from gregkalapos October 30, 2020 08:08
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 30, 2020 •
edited
Loading

Codecov Report

Merging #1000 (7505e7d) into master (9f5dcbf) will decrease coverage by 0.09%.
The diff coverage is 76.99%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   80.03%   79.93%   -0.10%     
==========================================
  Files         138      139       +1     
  Lines        6450     6663     +213     
==========================================
+ Hits         5162     5326     +164     
- Misses       1288     1337      +49
Impacted Files Coverage Δ
...m/Metrics/MetricsProvider/CgroupMetricsProvider.cs 75.74% <75.74%> (ø)
src/Elastic.Apm/Metrics/MetricsCollector.cs 87.58% <100.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f5dcbf...7505e7d. Read the comment docs.

@ghost
Copy link
Copy Markdown

ghost commented Nov 2, 2020 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-11-10T02:20:10.540+0000

  • Duration: 63 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 14554
Skipped 0
Total 14554

Steps errors 1

Expand to view the steps failures

  • Name: Build (took 2 min 7 sec) . View log details on here
    • Description: .ci/windows/dotnet.bat

@russcam
Copy link
Copy Markdown
Contributor Author

russcam commented Nov 3, 2020

jenkins run the tests please

gregkalapos
gregkalapos approved these changes Nov 4, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM.

@russcam
Copy link
Copy Markdown
Contributor Author

russcam commented Nov 9, 2020

jenkins run the tests please

@russcam russcam merged commit 5f5e555 into elastic:master Nov 10, 2020
@russcam russcam deleted the feature/cgroup-metrics branch November 10, 2020 03:48
@russcam russcam mentioned this pull request Nov 10, 2020
Closed
@russcam russcam added v1.7.0 enhancement New feature or request labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gregkalapos gregkalapos gregkalapos approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request v1.7.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reporting cgroup metrics

3 participants

@russcam @codecov-io @gregkalapos