Add elasticsearch_capture_body_urls option#670
Merged
github-actions[bot] merged 6 commits intomainfrom Aug 18, 2022
Merged
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
danielmitterdorfer
approved these changes
Aug 10, 2022
Member
danielmitterdorfer
left a comment
There was a problem hiding this comment.
Thanks for quick update! LGTM
trentm
reviewed
Aug 10, 2022
Member
trentm
left a comment
There was a problem hiding this comment.
Thanks for starting this Felix!
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
trentm
requested changes
Aug 11, 2022
Co-authored-by: Trent Mick <trent.mick@elastic.co>
basepi
approved these changes
Aug 11, 2022
trentm
approved these changes
Aug 11, 2022
z1c0
reviewed
Aug 12, 2022
Member
@felixbarny Are you okay with me changing that "Closes" to "Refs", so that the former issue isn't actually closed when this spec goes in? The issue should be closed when we implement the spec. Update: Oh, actually, I think what's wanted is: |
4 tasks
Member
Author
|
As this affects all agents at least in the way the default behaves, I have created implementation issues for all agents and I'm waiting two more days for objections. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: elastic/apm-agent-nodejs#2019
Closes: #665
We're only expecting to implement this in the Node.js agent in the near future.
Other agents may add this to their roadmap as they see fit but we won't create a cross-agent tracking issue.
sanitize_field_names) We're only capturing the request body for search requests by default to minimize the risk. Users can also add a custom ingest node pipeline to parse and redact JSON if needed.CODEOWNERS)/schedule 2022-08-18