Skip to content

Spec: services dependencies granularity Messaging#655

Merged
AlexanderWert merged 3 commits intoelastic:mainfrom
SylvainJuge:destination-granularity-messaging
Jul 18, 2022
Merged

Spec: services dependencies granularity Messaging#655
AlexanderWert merged 3 commits intoelastic:mainfrom
SylvainJuge:destination-granularity-messaging

Conversation

@SylvainJuge
Copy link
Copy Markdown
Member

@SylvainJuge SylvainJuge commented Jun 24, 2022

Part of #646 for messaging spans.

Specify which value of service.target.name we should use or the following span subtypes/instrumentations:

  • azurequeue : queue name
  • azureservicebus : queue or topic name
  • other: use already captured queue name

For AWS, Azure and other cloud-based services, we DO NOT use the region name as a fallback as we do for some services, the general rule is to always use the queue or topic name if available.

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Merge after 2 business days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.

@ghost
Copy link
Copy Markdown

ghost commented Jun 24, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-18T04:28:00.801+0000

  • Duration: 3 min 54 sec

@SylvainJuge SylvainJuge marked this pull request as ready for review July 11, 2022 07:05
@SylvainJuge SylvainJuge requested review from a team as code owners July 11, 2022 07:05
@SylvainJuge SylvainJuge removed request for a team July 11, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants