fix: replace buffer with memoryview for compatibility#289
Merged
ekzhu merged 1 commit intoekzhu:masterfrom Nov 16, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Python 3 compatibility issues by replacing the obsolete buffer() builtin (which only existed in Python 2) with memoryview(), the Python 3 equivalent. This resolves the F821 "undefined buffer" linting error.
- Replaces all occurrences of
buffer()withmemoryview()in deserialization methods - Removes the F821 ignore rule from pyproject.toml now that the issue is fixed
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Removes the F821 linting ignore rule now that buffer is fixed |
| datasketch/lean_minhash.py | Replaces buffer() with memoryview() in deserialize and setstate methods |
| datasketch/hyperloglog.py | Replaces buffer() with memoryview() in deserialize and setstate methods |
| datasketch/b_bit_minhash.py | Replaces buffer() with memoryview() in setstate method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ekzhu
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes
F821 undefined bufferby replacingbufferwithmemoryviewfor compatibility.Checklist