@ekzhu I have raised a PR. I have tried to cover all the points that we had discussed. Please feel free to engage and let me know if any modification is required. Thank you!

@ekzhu Resolved the conversations. Can you please go through the changes. Thank you. Let me know if there are any other changes.

Could you also add "3.12" to the tested python version:

https://github.com/ekzhu/datasketch/blob/master/.github/workflows/test.yml#L11

@ekzhu When will this commit be merged?

@junrae6454 Still waiting for @rupeshkumaar's changes. Unless you want to help finishing this?

Could you also add "3.12" to the tested python version:

https://github.com/ekzhu/datasketch/blob/master/.github/workflows/test.yml#L11

This is also done.

Could you also add "3.12" to the tested python version:
https://github.com/ekzhu/datasketch/blob/master/.github/workflows/test.yml#L11

This is also done.

Thanks. Let me know when the changes are pushed

Please do let me know, @ekzhu about the hashfunc for redis that I have asked. Thank you. Logging out for now. Once this is done I will push the changes.

@ekzhu Please review.

Also, to fix the tests failure for now, remove 3.12 from python version.

Please review @ekzhu

@rupeshkumaar merged, thank you for the hard work!!

@rupeshkumaar if you are interested, you can take a look at this issue #236 that broke the library for python 3.12

Yeah, sure I will take a look. @ekzhu