This arguably makes the code easier to read, and reduces one transpose .T operation.

the ndmin=2 is required for the transpose to be valid.

Thanks for the PR. Could you also add a guard rail in this function (or in init) to prevent cases when number of bands is less than 2?

I think putting it in the init would be better to avoid putting a branch in hot code.
However, in that case, should we just assert out when bands < 2( ==1)?

Contributor

Raise value error so caller knows what's wrong.

Is this inline with what you had in mind?

Is this inline with what you had in mind?

Yes.