Update default cluster version to Kubernetes v1.34#8645
Merged
naclonts merged 4 commits intoeksctl-io:mainfrom Jan 12, 2026
Merged
Update default cluster version to Kubernetes v1.34#8645naclonts merged 4 commits intoeksctl-io:mainfrom
naclonts merged 4 commits intoeksctl-io:mainfrom
Conversation
torredil
reviewed
Jan 5, 2026
Contributor
torredil
left a comment
There was a problem hiding this comment.
Will also need to bump up cluster version here:
to fix unit test:Summarizing 1 Failure:
[FAIL] nodegroup filter ForEach [It] should iterate over unique nodegroups, apply defaults and validate
| //TODO: Remove this and replace with output from DescribeClusterVersions endpoint | ||
| // DefaultVersion (default) | ||
| DefaultVersion = Version1_32 | ||
| DefaultVersion = Version1_34 |
Contributor
There was a problem hiding this comment.
cool with doing this change
long term we should replace this with the api response, not sure how much effort that is
Member
Author
Thanks for the tip - updated that test to use the |
NicholasBlaskey
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update default cluster version to Kubernetes v1.34, which is the current EKS default in the
DescribeClusterVersionsAPI.Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯