Allow creating Windows and Ubuntu nodegroups with NVIDIA GPU instances#5627
Merged
TiberiuGC merged 2 commits intoeksctl-io:mainfrom Aug 17, 2022
Conversation
Signed-off-by: Tibi <110664232+TiberiuGC@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Hello TiberiuGC 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website
cPu1
approved these changes
Aug 17, 2022
nikimanoledaki
approved these changes
Aug 17, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibi 110664232+TiberiuGC@users.noreply.github.com
Description
We should be able to create Windows and Ubuntu nodegroups with NVIDIA GPU instances, which is why we
are removing the previously configured error for this scenario. However, we will log a warning as these AMIs don't ship with GPU drivers installed and we don't want give the illusion that running GPU-accelerated workloads will work out of the box.
Fixes #5256
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯