Skip to content

Add p4de instance types to EFA plugin#5330

Merged
cPu1 merged 1 commit intoeksctl-io:mainfrom
cPu1:efa-plugin-update
May 27, 2022
Merged

Add p4de instance types to EFA plugin#5330
cPu1 merged 1 commit intoeksctl-io:mainfrom
cPu1:efa-plugin-update

Conversation

@cPu1
Copy link
Copy Markdown
Contributor

@cPu1 cPu1 commented May 27, 2022 •
edited
Loading

Description

Closes #5329

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cPu1 cPu1 added the kind/feature New feature or request label May 27, 2022
@cPu1 cPu1 mentioned this pull request May 27, 2022
Closed
@cPu1 cPu1 enabled auto-merge May 27, 2022 08:47
@cPu1 cPu1 merged commit 92c7ad3 into eksctl-io:main May 27, 2022
@ytsssun ytsssun mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Skarlso Skarlso Skarlso approved these changes

@nikimanoledaki nikimanoledaki nikimanoledaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Add P4de.24xlarge to the list of supported instances when setting efaEnabled: true

3 participants

@cPu1 @Skarlso @nikimanoledaki