Adding an option for --disable-nodegroup-eviction when deleting a cluster#4659
Merged
Skarlso merged 42 commits intoeksctl-io:mainfrom Jan 31, 2022
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When deleting a cluster that has pods with PDBs, I can not delete the whole cluster, since the nodes won't evict all of the workloads, causing the node groups draining step to fail.
Today, there is a flag when draining node groups of:
--disable-eviction, which ignores PDB errors while draining the node groups.I've added a flag:
--disable-nodegroup-eviction, that will exist when deleting a cluster, and achieves the same behavior of thedraincommand with the--disable-evictionflag (it literally calls the drain function with the same value).fixes #4416
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯