Skip to content

Adding an option for --disable-nodegroup-eviction when deleting a cluster#4659

Merged
Skarlso merged 42 commits intoeksctl-io:mainfrom
AmitBenAmi:disabling-nodes-eviction-when-deleting-cluster-with-force-flag
Jan 31, 2022
Merged

Adding an option for --disable-nodegroup-eviction when deleting a cluster#4659
Skarlso merged 42 commits intoeksctl-io:mainfrom
AmitBenAmi:disabling-nodes-eviction-when-deleting-cluster-with-force-flag

Conversation

@AmitBenAmi
Copy link
Copy Markdown
Contributor

@AmitBenAmi AmitBenAmi commented Jan 19, 2022

Description

When deleting a cluster that has pods with PDBs, I can not delete the whole cluster, since the nodes won't evict all of the workloads, causing the node groups draining step to fail.
Today, there is a flag when draining node groups of: --disable-eviction, which ignores PDB errors while draining the node groups.

I've added a flag: --disable-nodegroup-eviction, that will exist when deleting a cluster, and achieves the same behavior of the drain command with the --disable-eviction flag (it literally calls the drain function with the same value).

fixes #4416

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cluster deletion failed because of PodDisruptionBudget

5 participants