Use zone ID instead of zone name to avoid problematic zones#3947
Merged
cPu1 merged 4 commits intoeksctl-io:mainfrom Jul 8, 2021
Merged
Use zone ID instead of zone name to avoid problematic zones#3947cPu1 merged 4 commits intoeksctl-io:mainfrom
cPu1 merged 4 commits intoeksctl-io:mainfrom
Conversation
Contributor
|
@cPu1 we are not doing any more work on this until we speak at the product meeting this afternoon to get clearer requirements on this feature |
486c28d to
b34ffde
Compare
Contributor
|
are you still doing your last checkbox chetan, or is this complete and ready for review? |
Contributor
Author
It's complete, it's in the last commit. |
Callisto13
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AZ names across AWS accounts do not always map to the same location. This changelist uses the zone ID which is a unique identifier that always maps to the same location in every AWS account.
TODO:
Closes #3916
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯