Use Relative Error for Equality Comparison in Tests#114
Merged
RyanGlScott merged 3 commits intoekmett:masterfrom Jun 3, 2024
Merged
Use Relative Error for Equality Comparison in Tests#114RyanGlScott merged 3 commits intoekmett:masterfrom
RyanGlScott merged 3 commits intoekmett:masterfrom
Conversation
Collaborator
|
Thanks, @julmb! @sternenseemann, would you be able to test this patch on |
RyanGlScott
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make the tests more robust, we use relative error for equality comparison instead of absolute error or exact comparison. This should fix #113, but I do not have a
x86_64-darwinsetup to test this.I also did some cleanup first, I can split that part off into a separate PR if necessary.