enabled findings in bucket level monitor creation (opensearch-project#131)

eirsep · web-flow · commit 1b36aa13a107 · 2022-11-09T10:59:59.000-08:00
Signed-off-by: Surya Sashank Nistala &lt;snistala@amazon.com&gt;
diff --git a/src/main/java/org/opensearch/securityanalytics/transport/TransportIndexDetectorAction.java b/src/main/java/org/opensearch/securityanalytics/transport/TransportIndexDetectorAction.java
@@ -474,7 +474,7 @@ private IndexMonitorRequest createBucketLevelMonitorRequest(
                 detector.getAlertsHistoryIndex(),
                 detector.getAlertsHistoryIndexPattern(),
                 DetectorMonitorConfig.getRuleIndexMappingsByType(detector.getDetectorType()),
-                false), PLUGIN_OWNER_FIELD);
+                true), PLUGIN_OWNER_FIELD);
 
         return new IndexMonitorRequest(monitorId, SequenceNumbers.UNASSIGNED_SEQ_NO, SequenceNumbers.UNASSIGNED_PRIMARY_TERM, refreshPolicy, restMethod, monitor, null);
     }
diff --git a/src/test/java/org/opensearch/securityanalytics/resthandler/DetectorRestApiIT.java b/src/test/java/org/opensearch/securityanalytics/resthandler/DetectorRestApiIT.java
@@ -318,7 +318,13 @@ public void testCreatingADetectorWithAggregationRules() throws IOException {
 
         Response executeResponse = executeAlertingMonitor(bucketLevelMonitorId, Collections.emptyMap());
         Map<String, Object> executeResults = entityAsMap(executeResponse);
-        // TODO - check findings
+        // verify bucket level monitor findings
+        Map<String, String> params = new HashMap<>();
+        params.put("detector_id", createdRuleId);
+        Response getFindingsResponse = makeRequest(client(), "GET", SecurityAnalyticsPlugin.FINDINGS_BASE_URI + "/_search", params, null);
+        Map<String, Object> getFindingsBody = entityAsMap(getFindingsResponse);
+        assertNotNull(getFindingsBody);
+        Assert.assertEquals(1, getFindingsBody.get("total_findings"));
     }
     public void testUpdateADetector() throws IOException {
         String index = createTestIndex(randomIndex(), windowsIndexMapping());

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,7 @@ private IndexMonitorRequest createBucketLevelMonitorRequest(`
`474`	`474`	`detector.getAlertsHistoryIndex(),`
`475`	`475`	`detector.getAlertsHistoryIndexPattern(),`
`476`	`476`	`DetectorMonitorConfig.getRuleIndexMappingsByType(detector.getDetectorType()),`
`477`		`- false), PLUGIN_OWNER_FIELD);`
	`477`	`+ true), PLUGIN_OWNER_FIELD);`
`478`	`478`
`479`	`479`	`return new IndexMonitorRequest(monitorId, SequenceNumbers.UNASSIGNED_SEQ_NO, SequenceNumbers.UNASSIGNED_PRIMARY_TERM, refreshPolicy, restMethod, monitor, null);`
`480`	`480`	`}`