Merged
Conversation
Stop writing docspell config files to the world-readable nix store, since they contain sensitive info, e.g. database passwords. Additionally, provide a `configFile` option so users may point to a file they've secured using their prefered secret management strategy.
Owner
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the NixOS module to handle config files more securely.
This addresses some of the low-hanging fruit identified in #2451
1) Stop writing config files to the world-readable nix store
Instead, write to
/etc/docspell-restserver.confand/etc/docspell-joex.confreadable only by the docspell user.2) Provide a
configFileoptionAllow the user to specify the path to a config file. They can use this to point to a file they've secured with their preferred secret management scheme (to avoid leaking sensitive info in the nixos configuration itself).
Only generate a config file if this option is left unspecified.
Example usage:
https://codeberg.org/ivanbrennan/nixos-config/commit/0d34b183dfe3e04421cb6044e67d974b83260630