Replace http4s-blaze-client with http4s-ember-client.#2315
Merged
eikek merged 1 commit intoeikek:masterfrom Oct 23, 2023
Merged
Replace http4s-blaze-client with http4s-ember-client.#2315eikek merged 1 commit intoeikek:masterfrom
http4s-blaze-client with http4s-ember-client.#2315eikek merged 1 commit intoeikek:masterfrom
Conversation
Owner
|
Thank you very much! This is one part of the issue. There is the server part left, which is probably a bit more complex to adapt. |
Author
|
Yes I realized that and stared working on it. But I did not commit that change as it is a bit big and might require some additional testing. Possibly, that could be a separate PR. |
Owner
Yes sure! Thanks a lot for looking into this! |
f5f7954 to
438d165
Compare
Author
|
I think the build failed due to scalafix errors. I have fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2221. The issue is marked complex so I am not sure if I missed something so please provide feedback.