Merged
Conversation
0ef763d to
5b7720c
Compare
th7nder
suggested changes
Sep 17, 2024
Contributor
th7nder
left a comment
There was a problem hiding this comment.
lots of changes that look unrelated to tests, some clean-up needed
i like this zombienet sdk (waaay better than the bash script)
th7nder
previously approved these changes
Sep 17, 2024
neutrinoks
reviewed
Sep 17, 2024
neutrinoks
reviewed
Sep 17, 2024
neutrinoks
previously approved these changes
Sep 17, 2024
Contributor
neutrinoks
left a comment
There was a problem hiding this comment.
I still feel lost 🙈 but it looks good 😄
neutrinoks
previously approved these changes
Sep 17, 2024
b0ced5a to
362b79f
Compare
Contributor
Author
|
I'll be the first to admit that it got a bit out of scope, but I noticed that I was duplicating types and had to organize them all. Still not perfect, will need more iteration in the future to further reduce the surface size. |
neutrinoks
reviewed
Sep 18, 2024
aidan46
reviewed
Sep 18, 2024
aidan46
reviewed
Sep 18, 2024
Contributor
|
I really like how it's coming together. I have no suggestions 💪 You have my approval 😄 |
cernicc
previously approved these changes
Sep 18, 2024
aidan46
approved these changes
Sep 18, 2024
cernicc
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement a test suite (Ma'at) for the parachain.
Fixes #351
Checklist