Fix for the issue#1554: UserManagedCacheBuilder tries to create serialize… #3122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdennis
requested changes
Feb 3, 2023
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
| LOGGER.info("Serializers for cache '{}' failed creation ({}). However, depending on the configuration, they might not be needed", id, e.getMessage()); |
Member
There was a problem hiding this comment.
We should probably leave this at debug to match EhcacheManager.
chrisdennis
approved these changes
Feb 3, 2023
3ffe72e to
5a94eed
Compare
Member
|
This is good but needs rebasing against latest main. |
bbb982a to
1b66d81
Compare
chrisdennis
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1554 : modified the catch block while creating serializers