Merged
Conversation
Contributor
|
Can you run |
Collaborator
Author
|
Sure! I did run it before raising PR but I think I set wrong go version(1.16). |
bwplotka
approved these changes
Jun 9, 2021
Contributor
bwplotka
left a comment
There was a problem hiding this comment.
Solid, proposed one idea, otherwise LGTM!
README.md
Outdated
| bingo get -u github.com/efficientgo/tools/copyright | ||
| ``` | ||
|
|
||
| ### Module `github.com/efficientgo/tools/extflag` |
Contributor
There was a problem hiding this comment.
Suggested change
| ### Module `github.com/efficientgo/tools/extflag` | |
| ### Module `github.com/efficientgo/tools/extkingpin |
README.md
Outdated
|
|
||
| This module provides the PathOrContent flag type which defines two flags to fetch bytes. Either from file (\*-file flag) or content (\* flag). Also returns the content of a YAML file with substituted environment variables. | ||
|
|
||
| ```go mdox-gen-exec="sh -c 'tail -n +6 extflag/doc.go'" |
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
1d2ce39 to
10b0347
Compare
This was referenced Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in the
extkingpinmodule which provides thePathOrContentflag with environment variable substitution.