Use Inspect-API instead of root domain setup #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Deleted babel-plugin, macros, redux-devtools and effector-inspector integrations BREAKING CHANGE: Deleted a bunch of irrelevant to inspect-api features. Logger will be simplified from one-for-all adapter to specifically console adapter
acf6706 to
ef20e02
Compare
logger internals are transferred to Inspect API, public api also changes BREAKING CHANGE: Public API now requires explicit `attachLogger` call
BREAKING CHANGE: effector 22.8.3 now minimal requried version of effector for effector-logger to work
CRA is deprecated BREAKING CHANGE: There is no CRA support via babel-macros anymore
There are now tests that are run against dist. Dist also updated to not include incorrect files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
effector-loggeris re-written to use brand new Inspect API of effector. Root domain setups, custom babel-plugins and etc are no longer needed.Simple
attachLogger()call somewhere in your app entrypoint is enough now.Also
effector-loggernow only does console logs and Redux DevTools support and effector-inspector integrations are removed. Use@effector/redux-devtools-adapterandeffector-inspectorinstead.BREAKING CHANGES
@effector/redux-devtools-adapterandeffector-inspectorinstead.effector-logger/attachis removed. Use mainattachLoggerexport instead. Notice, that config shape is different and does not require root domain now.effector-logger/babel-pluginis removed. It is no longer needed, just useeffector/babel-pluginor@effector/swc-pluginnormally.import { createEvent, ... } from "effector-logger"support is removed. Usepatronum/debugfrom patronum.effector.dev instead if you need to log only some units.Vite) instead.New features
configurenow supportslog: 'enabled'option to forcefully log some unit that is usually omitted. It is useful to log updates of derived units which are omitted byeffector-loggerby default.Scopelogs are fully supported now, domain is not requirednameprefix to your logs if needed. It can be useful in case if there are few instances of your app which are using different scopes.Maintenance
Old integration tests are removed. Now there is a single suit of
vitest-based tests which is run againstdistoutput of the library bundler.