Skip to content

Fix global state impact on scopes #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zerobias merged 5 commits into from
Jul 19, 2023
Merged

Fix global state impact on scopes #909

zerobias merged 5 commits into from
Jul 19, 2023

Conversation

@zerobias
Copy link
Member

@zerobias zerobias commented May 24, 2023 •
edited
Loading

fix #535

@zerobias
Add tests for global state impact
3c5a9ab 
this commit should fail
@zerobias zerobias added this to the effector Spacewatch 23.0.0 milestone May 24, 2023
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented May 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@zerobias zerobias requested a review from AlexandrHoroshih May 24, 2023 19:46
@zerobias zerobias changed the title Fix global state impact on scopes (fix #535) Fix global state impact on scopes May 24, 2023
@zerobias zerobias mentioned this pull request May 24, 2023
Closed
75 tasks
AlexandrHoroshih
AlexandrHoroshih approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@AlexandrHoroshih AlexandrHoroshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sergeysova sergeysova changed the base branch from master to release/v23 July 6, 2023 06:34
@zerobias zerobias merged commit e16012e into release/v23 Jul 19, 2023
@zerobias zerobias deleted the fix-no-scope-affect-scope branch July 19, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexandrHoroshih AlexandrHoroshih AlexandrHoroshih approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

effector Spacewatch 23.0.0

Development

Successfully merging this pull request may close these issues.

No scope events affect scoped stores

3 participants

@zerobias @AlexandrHoroshih