Skip to content

Fix type degradation from 22.8.2 #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorkamyshev merged 2 commits into from
May 17, 2023
Merged

Fix type degradation from 22.8.2 #902

igorkamyshev merged 2 commits into from
May 17, 2023

Conversation

@igorkamyshev
Copy link
Member

@igorkamyshev igorkamyshev commented May 17, 2023 •
edited
Loading

Some degradation of typings was introduced in https://github.com/effector/effector/pull/884/files

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented May 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@zerobias zerobias self-requested a review May 17, 2023 11:09
zerobias
zerobias approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@zerobias zerobias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@igorkamyshev igorkamyshev merged commit 8ea9004 into master May 17, 2023
@igorkamyshev igorkamyshev deleted the fix-22-8-2-type-degradation branch May 17, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zerobias zerobias zerobias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorkamyshev @zerobias