Skip to content

Tests and types for useUnit #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zerobias merged 5 commits into from
Jun 23, 2022
Merged

Tests and types for useUnit #733

zerobias merged 5 commits into from
Jun 23, 2022

Conversation

@AlexandrHoroshih
Copy link
Member

@AlexandrHoroshih AlexandrHoroshih commented Jun 23, 2022

  • Adds missing tests and typings for brand new useUnit

@AlexandrHoroshih AlexandrHoroshih marked this pull request as ready for review June 23, 2022 18:07
@AlexandrHoroshih AlexandrHoroshih force-pushed the use-unit-missing-parts branch from f4ec6de to 2153168 Compare June 23, 2022 18:08
@AlexandrHoroshih AlexandrHoroshih requested review from Drevoed, sergeysova and zerobias and removed request for sergeysova June 23, 2022 18:08
zerobias
zerobias approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@zerobias zerobias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! 🔥 Thanks!

@zerobias zerobias merged commit 5fe8149 into master Jun 23, 2022
@zerobias zerobias deleted the use-unit-missing-parts branch June 23, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zerobias zerobias zerobias approved these changes

@sergeysova sergeysova Awaiting requested review from sergeysova

@Drevoed Drevoed Awaiting requested review from Drevoed

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexandrHoroshih @zerobias