Skip to content

New sample types #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zerobias merged 4 commits into from
Jan 27, 2021
Merged

New sample types #445

zerobias merged 4 commits into from
Jan 27, 2021

Conversation

@doasync
Copy link
Member

@doasync doasync commented Jan 24, 2021

No description provided.

@netlify
Copy link

netlify bot commented Jan 24, 2021 •
edited
Loading

Deploy request for effector-docs pending review.

Review with commit b644373

https://app.netlify.com/sites/effector-docs/deploys

zerobias
zerobias reviewed Jan 24, 2021
View reviewed changes
src/types/__tests__/effector/sample/sample.test.ts Outdated
expect(typecheck).toMatchInlineSnapshot(`
"
no errors
Expected 2 type arguments, but got 1.
Copy link
Member

@zerobias zerobias Jan 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regression

Copy link
Member Author

@doasync doasync Jan 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I can solve it)

@doasync doasync changed the title New sample types (for generated type tests) New sample types (proof of concept) Jan 24, 2021
@doasync doasync changed the title New sample types (proof of concept) New sample types Jan 26, 2021
@zerobias zerobias marked this pull request as ready for review January 27, 2021 01:39
@zerobias
Copy link
Member

zerobias commented Jan 27, 2021

Fantastic work! This going to be a huge improvement in developer experience 🚀

@zerobias zerobias merged commit 1f1fa76 into effector:master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zerobias zerobias zerobias left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doasync @zerobias