Skip to content

add support for attach without mapParams and source simultaneously #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zerobias merged 4 commits into from
Oct 9, 2020
Merged

add support for attach without mapParams and source simultaneously #396

zerobias merged 4 commits into from
Oct 9, 2020

Conversation

@sergeysova
Copy link
Member

@sergeysova sergeysova commented Oct 7, 2020 

const originalFx = createEffect(() => {
  // your logic
})

const derivedFx = attach({ effect: originalFx })

inspired by: effector/patronum#79

@sergeysova sergeysova requested a review from zerobias October 7, 2020 12:16
@sergeysova sergeysova marked this pull request as draft October 7, 2020 12:16
@sergeysova sergeysova marked this pull request as ready for review October 7, 2020 14:24
@doasync
Copy link
Member

doasync commented Oct 7, 2020 •
edited
Loading

It doesn't attach anything

@sergeysova
Copy link
Member Author

sergeysova commented Oct 7, 2020

@doasync Do you have any suggestions?

@zerobias
Copy link
Member

zerobias commented Oct 8, 2020

attach new effect to given one

@doasync
Copy link
Member

doasync commented Oct 8, 2020 •
edited
Loading

attach new effect to given one

Oh, well, then, yeah, okay 👌

zerobias
zerobias approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@zerobias zerobias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid pr, thanks!

@zerobias zerobias merged commit 007422b into master Oct 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the feat/attach-without-source-and-mapParams branch October 9, 2020 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zerobias zerobias zerobias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sergeysova @doasync @zerobias @oas89